Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 106533003: Allowing following of symlinks for script resources from extensions (Closed)

Created:
7 years ago by blois
Modified:
6 years, 11 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Allowing following of symlinks for script resources from extensions Support for following symlinks was added with https://chromiumcodereview.appspot.com/10387035/ but it's been broken for script resources because the proper flags were not being propagated. This only allows following symlinks if the extension was an unpacked extension. BUG=27185 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244370

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Fixing typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/extensions/extension_protocols.cc View 1 2 5 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
blois
Not sure what the process is to fix this bug, but it's been causing lots ...
7 years ago (2013-12-09 22:50:49 UTC) #1
benwells
https://codereview.chromium.org/106533003/diff/1/chrome/browser/extensions/extension_protocols.cc File chrome/browser/extensions/extension_protocols.cc (right): https://codereview.chromium.org/106533003/diff/1/chrome/browser/extensions/extension_protocols.cc#newcode546 chrome/browser/extensions/extension_protocols.cc:546: follow_symlinks_anywhere = extension->creation_flags(); What is this line for - ...
7 years ago (2013-12-09 23:22:15 UTC) #2
blois
https://codereview.chromium.org/106533003/diff/1/chrome/browser/extensions/extension_protocols.cc File chrome/browser/extensions/extension_protocols.cc (right): https://codereview.chromium.org/106533003/diff/1/chrome/browser/extensions/extension_protocols.cc#newcode546 chrome/browser/extensions/extension_protocols.cc:546: follow_symlinks_anywhere = extension->creation_flags(); On 2013/12/09 23:22:15, benwells wrote: > ...
7 years ago (2013-12-09 23:31:06 UTC) #3
benwells
lgtm
7 years ago (2013-12-09 23:49:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blois@google.com/106533003/40001
6 years, 11 months ago (2014-01-11 00:44:34 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 22:38:52 UTC) #6
Message was sent while issue was closed. 
Change committed as 244370

Powered by Google App Engine
This is Rietveld 408576698