Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 106533002: Don't unmap ports in host_driven/test_case.py. (Closed)

Created:
7 years ago by Philippe
Modified:
7 years ago
Reviewers:
bulach
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Don't unmap ports in host_driven/test_case.py. The sync tests failure seems to have to do with port unmapping. Not unmapping ports let most of the sync tests pass (only 2 failures remain for an unrelated reason apparently). Note that port unmapping was added to avoid exceeding the file descriptor limit in net_unittests since each test server was listening on a different port. The sync tests use a server always listening on a same port so unmapping the port is not strictly needed. BUG=313809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M build/android/pylib/host_driven/test_case.py View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Philippe
Hi Marcus, I have this partial workaround for the sync tests downstream (that seem to ...
7 years ago (2013-12-05 13:51:17 UTC) #1
bulach
lgtm but...ouch... :( what is the issue with unmapping? why is it failing? this seems ...
7 years ago (2013-12-06 10:53:19 UTC) #2
Philippe
I don't fully understand what's happening here to be honest but the problem seems to ...
7 years ago (2013-12-09 09:21:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/106533002/1
7 years ago (2013-12-09 09:21:40 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-09 11:13:28 UTC) #5
Message was sent while issue was closed.
Change committed as 239467

Powered by Google App Engine
This is Rietveld 408576698