Start caching masks / stroke fills for textblobs

Start caching masks / stroke fills for textblobs

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/53b5f4488b05c40254b24c718c2df9724a13c54a

[joshualitt, 2015-04-08 15:09:44]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com, robertphillips@google.com

[joshualitt, 2015-04-08 15:14:10]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-04-08 15:14:11]

small change to start caching masks / stroke info along with the blob

[bsalomon, 2015-04-08 15:38:19]

https://codereview.chromium.org/1065293003/diff/50001/src/gpu/GrAtlasTextCont...
File src/gpu/GrAtlasTextContext.h (right):

https://codereview.chromium.org/1065293003/diff/50001/src/gpu/GrAtlasTextCont...
src/gpu/GrAtlasTextContext.h:147: SkMaskFilter::BlurRec fBlurRec;
As we discussed, perhaps this should be a bit here to disallow multiple blurred
versions of a blob to the cache (animation) and the blur params are compared on
a cache hit.

https://codereview.chromium.org/1065293003/diff/50001/src/gpu/GrAtlasTextCont...
src/gpu/GrAtlasTextContext.h:148: struct StrokeInfo {
similar here I think, style says its stroked, probably only want one stroked
cache entry per blob.

[joshualitt, 2015-04-08 17:08:02]

On 2015/04/08 15:38:19, bsalomon wrote:
>
https://codereview.chromium.org/1065293003/diff/50001/src/gpu/GrAtlasTextCont...
> File src/gpu/GrAtlasTextContext.h (right):
> 
>
https://codereview.chromium.org/1065293003/diff/50001/src/gpu/GrAtlasTextCont...
> src/gpu/GrAtlasTextContext.h:147: SkMaskFilter::BlurRec fBlurRec;
> As we discussed, perhaps this should be a bit here to disallow multiple
blurred
> versions of a blob to the cache (animation) and the blur params are compared
on
> a cache hit.
> 
>
https://codereview.chromium.org/1065293003/diff/50001/src/gpu/GrAtlasTextCont...
> src/gpu/GrAtlasTextContext.h:148: struct StrokeInfo {
> similar here I think, style says its stroked, probably only want one stroked
> cache entry per blob.

feedback incorporated

[bsalomon, 2015-04-08 17:36:10]

On 2015/04/08 17:08:02, joshualitt wrote:
> On 2015/04/08 15:38:19, bsalomon wrote:
> >
>
https://codereview.chromium.org/1065293003/diff/50001/src/gpu/GrAtlasTextCont...
> > File src/gpu/GrAtlasTextContext.h (right):
> > 
> >
>
https://codereview.chromium.org/1065293003/diff/50001/src/gpu/GrAtlasTextCont...
> > src/gpu/GrAtlasTextContext.h:147: SkMaskFilter::BlurRec fBlurRec;
> > As we discussed, perhaps this should be a bit here to disallow multiple
> blurred
> > versions of a blob to the cache (animation) and the blur params are compared
> on
> > a cache hit.
> > 
> >
>
https://codereview.chromium.org/1065293003/diff/50001/src/gpu/GrAtlasTextCont...
> > src/gpu/GrAtlasTextContext.h:148: struct StrokeInfo {
> > similar here I think, style says its stroked, probably only want one stroked
> > cache entry per blob.
> 
> feedback incorporated

lgtm

[joshualitt, 2015-04-13 13:15:30]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-04-13 13:15:30]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1065293003/#ps310001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-13 13:15:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1065293003/310001

[commit-bot: I haz the power, 2015-04-13 13:34:05]

Committed patchset #17 (id:310001) as
https://skia.googlesource.com/skia/+/53b5f4488b05c40254b24c718c2df9724a13c54a