Issue 1065223003: Cleanup resolving of 'em' units in SVGLengthContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1065223003: Cleanup resolving of 'em' units in SVGLengthContext (Closed)

Created:
5 years, 8 months ago by fs

Modified:
5 years, 8 months ago

Reviewers:
Erik Dahlström (inactive)

CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Cleanup resolving of 'em' units in SVGLengthContext With the 'rem' unit added, there's some duplication, since the only difference between 'em' and 'rem' is where the style comes from. By splitting the resolution of the style out of the methods that convert to/from 'em' (and 'rem'), the same two functions can be used to compute the results in both the 'em' and 'rem' case - just feeding them with different ComputedStyle objects. BUG=368598, 470449 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193547

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -90 lines)			Patch
	M	Source/core/svg/SVGLengthContext.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	Source/core/svg/SVGLengthContext.cpp	View		5 chunks	+52 lines, -84 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065223003/1

5 years, 8 months ago (2015-04-10 12:52:00 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-10 14:19:38 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193547

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages