Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1065213002: Make GetDebugContext a bit more robust. (Closed)

Created:
5 years, 8 months ago by Sven Panne
Modified:
5 years, 8 months ago
Reviewers:
Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make GetDebugContext a bit more robust. Perhaps we should throw an exception and/or change our external API to use a MaybeLocal, but that would be a bigger change. For now, we just return undefined when something goes wrong with the DebugContext, which is good enough to avoid crashing. BUG=chromium:474538 LOG=y Committed: https://crrev.com/18455418253cf62a32f6adcd546db9021817c0ca Cr-Commit-Position: refs/heads/master@{#27650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sven Panne
5 years, 8 months ago (2015-04-08 07:34:33 UTC) #2
Yang
On 2015/04/08 07:34:33, Sven Panne wrote: LGTM. Maybe a test case?
5 years, 8 months ago (2015-04-08 08:02:18 UTC) #3
Sven Panne
On 2015/04/08 08:02:18, Yang wrote: > On 2015/04/08 07:34:33, Sven Panne wrote: > > LGTM. ...
5 years, 8 months ago (2015-04-08 09:08:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065213002/1
5 years, 8 months ago (2015-04-08 09:08:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 09:10:17 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 09:10:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18455418253cf62a32f6adcd546db9021817c0ca
Cr-Commit-Position: refs/heads/master@{#27650}

Powered by Google App Engine
This is Rietveld 408576698