Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 10652: Change the accelerator key for Javascript debugger and console to avoid using VK_OEM3 (Closed)

Created:
12 years, 1 month ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change the accelerator key for Javascript debug to Ctrl-Shift-D from 'Alt-`' BUG=3696, 5087 TEST=Install non-en-US keyboard and switch keyboards to one of them (e.g. German, French, Russian) and make sure that shortcut keys for Javascript debug remains 'Ctrl-Shift-L'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6438

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/app/chrome_dll.rc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jungshik at Google
12 years, 1 month ago (2008-11-12 20:49:56 UTC) #1
Glen Murphy
Can we use Ctrl+~ or similar instead? Ctrl+Shift+D is too close to bookmarking. I'd even ...
12 years, 1 month ago (2008-11-12 20:54:50 UTC) #2
jungshik at Google
On 2008/11/12 20:54:50, Glen Murphy wrote: > Can we use Ctrl+~ or similar instead? Ctrl+Shift+D ...
12 years, 1 month ago (2008-11-13 01:09:06 UTC) #3
Glen Murphy
I vote for Ctrl+Shift+L = Javascript Debugger (mapping to Firebug's command line shortcut) Ctrl+Shift+J = ...
12 years, 1 month ago (2008-11-14 21:12:11 UTC) #4
jungshik at Google
On 2008/11/14 21:12:11, Glen Murphy wrote: > I vote for > Ctrl+Shift+L = Javascript Debugger ...
12 years ago (2008-12-04 19:56:07 UTC) #5
Glen Murphy
12 years ago (2008-12-04 20:23:03 UTC) #6
LGTM

On 2008/12/04 19:56:07, Jungshik Shin wrote:
> On 2008/11/14 21:12:11, Glen Murphy wrote:
> > I vote for 
> > Ctrl+Shift+L = Javascript Debugger (mapping to Firebug's command line
> shortcut)
> > Ctrl+Shift+J = Javascript Console (mapping to Firefox's console shortcut)
> 
> Ok. I just did that. Can you take a look again?

Powered by Google App Engine
This is Rietveld 408576698