Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1065153002: Record add to homescreen events with URL from the owning web contents. (Closed)

Created:
5 years, 8 months ago by benwells
Modified:
5 years, 8 months ago
Reviewers:
Bernhard Bauer, gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record add to homescreen events with URL from the owning web contents. This change fixes a bug in 42 which is triggered if the start URL from the manifest is not the same as the current page. In this case, the fact that the shortcut was added is not remembered, causing the banner to come up in future. BUG=474631 Committed: https://crrev.com/ee0b4d8b42ca2da99dd6ea1dac62690fa0a747bc Cr-Commit-Position: refs/heads/master@{#324198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/android/shortcut_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
benwells
This isn't yet tested but trying to get an early review. I'll test before landing.
5 years, 8 months ago (2015-04-08 03:07:33 UTC) #2
gone
lgtm, should be fine
5 years, 8 months ago (2015-04-08 03:11:02 UTC) #3
benwells
+bauerb for owners review. This is to be merged into 42 to fix the referenced ...
5 years, 8 months ago (2015-04-08 08:16:52 UTC) #5
benwells
On 2015/04/08 08:16:52, benwells wrote: > +bauerb for owners review. This is to be merged ...
5 years, 8 months ago (2015-04-08 08:17:17 UTC) #6
Bernhard Bauer
lgtm
5 years, 8 months ago (2015-04-08 08:18:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065153002/1
5 years, 8 months ago (2015-04-08 08:19:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 08:22:53 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 08:23:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee0b4d8b42ca2da99dd6ea1dac62690fa0a747bc
Cr-Commit-Position: refs/heads/master@{#324198}

Powered by Google App Engine
This is Rietveld 408576698