Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1065123002: Mac: Partially enable partial swap (Closed)

Created:
5 years, 8 months ago by ccameron
Modified:
5 years, 8 months ago
Reviewers:
jbauman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Partially enable partial swap We draw all contents in the IOSurface and remote CALayer paths into a buffer, which we then draw to the screen. A partial swap here means that we partially re-drew the buffer. This isn't a complete partial swap, because, in both of these cases, we still re-draw the full buffer to the screen. While I'm in the neighborhood, clean up how we track the size of the frame, since that is particularly confusing (especially when we have partial swaps that would, more logically, pass in the damage rect). BUG=474299 Committed: https://crrev.com/c85aba5fa461901d8b76c4fe26719ec6056abd20 Cr-Commit-Position: refs/heads/master@{#324658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -17 lines) Patch
M content/common/gpu/image_transport_surface_calayer_mac.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_calayer_mac.mm View 1 chunk +7 lines, -2 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.h View 2 chunks +8 lines, -3 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.mm View 5 chunks +11 lines, -6 lines 0 comments Download
M content/common/gpu/image_transport_surface_iosurface_mac.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_iosurface_mac.cc View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ccameron
5 years, 8 months ago (2015-04-08 00:26:57 UTC) #2
jbauman
lgtm, though this is semantically more of a preserve than a partial swap. Luckily the ...
5 years, 8 months ago (2015-04-08 00:40:31 UTC) #3
ccameron
Thanks!
5 years, 8 months ago (2015-04-10 16:48:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065123002/1
5 years, 8 months ago (2015-04-10 16:48:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 17:44:06 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 17:45:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c85aba5fa461901d8b76c4fe26719ec6056abd20
Cr-Commit-Position: refs/heads/master@{#324658}

Powered by Google App Engine
This is Rietveld 408576698