Issue 1065093003: Generate trace header/footer in tracing consumer instead of service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1065093003: Generate trace header/footer in tracing consumer instead of service (Closed)

Created:
5 years, 8 months ago by jamesr

Modified:
5 years, 8 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Generate trace header/footer in tracing consumer instead of service Having the output of the tracing service be a list of json objects instead of one json object makes it much easier to combine multiple sources. This teaches skydb (which wants to format the output into a json file loadable by trace-viewer) to emit the tracing header/footer itself. This will make it possible to combine data from the tracing service with data collected by the shell itself. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fd120c427fe5ea689e3fdc8ae1ee7c5654313d54

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -15 lines)			Patch
M	services/tracing/trace_data_sink.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	services/tracing/trace_data_sink.cc	View	2 chunks	+1 line, -13 lines	0 comments	Download
M	services/tracing/tracing_app.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tools/skydb	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

5 years, 8 months ago (2015-04-09 23:51:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fd120c427fe5ea689e3fdc8ae1ee7c5654313d54 (presubmit successful).

Expand Messages | Collapse Messages