Issue 1065073002: Attempt to de-flake tests/framework/basic.sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1065073002: Attempt to de-flake tests/framework/basic.sky (Closed)

Created:
5 years, 8 months ago by eseidel

Modified:
5 years, 8 months ago

Reviewers:
ojan, Hixie

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Attempt to de-flake tests/framework/basic.sky new Image() is likely to cause the image to try and load as soon as the underlying Image element is inserted into the real DOM. This at least points it at a real image so that it won't dump 404 response text into the test output if the image load kicks off before the test completes. Example: http://build.chromium.org/p/client.mojo/builders/Mojo%20Linux%20NaCl/builds/1130/steps/Sky%20tests/logs/stdio R=ianh@google.com, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b29188e948f87c07ba28b829df201545b443fe2d

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sky/tests/framework/basic.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

eseidel

5 years, 8 months ago (2015-04-07 22:53:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b29188e948f87c07ba28b829df201545b443fe2d (presubmit successful).