Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1064983002: [Effen] basic layout container class for custom layout (Closed)

Created:
5 years, 8 months ago by Hixie
Modified:
5 years, 8 months ago
Reviewers:
ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Custom layout. For now, FixedHeightScrollable uses a custom BlockLayout algorithm, mostly as a proof of concept. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f9d3f0b9d9eaf5123fdb3fa77dcb49e07fc5a94d

Patch Set 1 #

Total comments: 2

Patch Set 2 : it works! #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
M sky/framework/components/fixed_height_scrollable.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sky/framework/fn.dart View 1 1 chunk +36 lines, -0 lines 7 comments Download
A sky/framework/layouts/block.dart View 1 1 chunk +30 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (1 generated)
ojan
https://codereview.chromium.org/1064983002/diff/1/sky/framework/layouts/block.dart File sky/framework/layouts/block.dart (right): https://codereview.chromium.org/1064983002/diff/1/sky/framework/layouts/block.dart#newcode20 sky/framework/layouts/block.dart:20: double y = 0.0; FYI, here you should be ...
5 years, 8 months ago (2015-04-08 20:08:12 UTC) #2
Hixie
https://codereview.chromium.org/1064983002/diff/1/sky/framework/layouts/block.dart File sky/framework/layouts/block.dart (right): https://codereview.chromium.org/1064983002/diff/1/sky/framework/layouts/block.dart#newcode20 sky/framework/layouts/block.dart:20: double y = 0.0; On 2015/04/08 20:08:11, ojan wrote: ...
5 years, 8 months ago (2015-04-09 16:26:39 UTC) #3
ojan
On 2015/04/09 at 16:26:39, ianh wrote: > https://codereview.chromium.org/1064983002/diff/1/sky/framework/layouts/block.dart > File sky/framework/layouts/block.dart (right): > > https://codereview.chromium.org/1064983002/diff/1/sky/framework/layouts/block.dart#newcode20 ...
5 years, 8 months ago (2015-04-10 23:38:31 UTC) #4
ojan
The only thing I think we should try to work out before committing here is ...
5 years, 8 months ago (2015-04-13 21:49:27 UTC) #5
Hixie
https://codereview.chromium.org/1064983002/diff/20001/sky/framework/fn.dart File sky/framework/fn.dart (right): https://codereview.chromium.org/1064983002/diff/20001/sky/framework/fn.dart#newcode591 sky/framework/fn.dart:591: On 2015/04/13 at 21:49:27, ojan wrote: > Nit: The ...
5 years, 8 months ago (2015-04-13 23:16:02 UTC) #6
ojan
lgtm I'm OK with trying this for now and seeing if it's painful.
5 years, 8 months ago (2015-04-14 00:34:31 UTC) #7
Hixie
5 years, 8 months ago (2015-04-14 17:38:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f9d3f0b9d9eaf5123fdb3fa77dcb49e07fc5a94d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698