media/video/capture/fake_video_capture_device.h - Issue 1064963002: VideoCapture: add support for GpuMemoryBuffer allocation and lifetime mgmt in VideoCaptureBufferPool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/fake_video_capture_device.h

Issue 1064963002: VideoCapture: add support for GpuMemoryBuffer allocation and lifetime mgmt in VideoCaptureBufferPool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: VideoCaptureDevice::Client::Buffer::~Buffer() pure virtual. Avoid using base::MessageLoopProxy::cur… Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/video/capture/fake_video_capture_device.h

diff --git a/media/video/capture/fake_video_capture_device.h b/media/video/capture/fake_video_capture_device.h

index e785ce61202e3f829f23319465ba02df680ac828..f4a19f9edb9c2c6611aa8d66cc15094f905ead7f 100644

--- a/media/video/capture/fake_video_capture_device.h

+++ b/media/video/capture/fake_video_capture_device.h

@@ -23,8 +23,9 @@ class MEDIA_EXPORT FakeVideoCaptureDevice : public VideoCaptureDevice {

public:

enum FakeVideoCaptureDeviceType {

USING_OWN_BUFFERS,

- USING_CLIENT_BUFFERS,

- USING_GPU_MEMORY_BUFFERS,

+ USING_OWN_BUFFERS_TRIPLANAR,

+ USING_CLIENT_BUFFERS_I420,

+ USING_CLIENT_BUFFERS_GPU,

};

static int FakeCapturePeriodMs() { return kFakeCapturePeriodMs; }

@@ -41,8 +42,7 @@ class MEDIA_EXPORT FakeVideoCaptureDevice : public VideoCaptureDevice {

static const int kFakeCapturePeriodMs = 50;

void CaptureUsingOwnBuffers();

- void CaptureUsingClientBuffers();

- void CaptureUsingGpuMemoryBuffers();

+ void CaptureUsingClientBuffers(VideoPixelFormat pixel_format);

void BeepAndScheduleNextCapture(const base::Closure& next_capture);

// |thread_checker_| is used to check that all methods are called in the

« no previous file with comments | « media/base/video_capture_types.cc ('k') | media/video/capture/fake_video_capture_device.cc » ('j') | no next file with comments »