Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1064913002: Revert of Update OTS to revision 6d2e08b (Closed)

Created:
5 years, 8 months ago by zhaoqin1
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update OTS to revision 6d2e08b (patchset #1 id:1 of https://codereview.chromium.org/1062093002/) Reason for revert: This CL caused many tests fail on uninit read errors reported by MSan BUG=474597 Original issue's description: > Update OTS to revision 6d2e08b > > This brings in a bugfix of checksum calculation that caused assertion > failure on debug builds. > > BUG=464780 > > Committed: https://crrev.com/3a672fe050438bc787af3f9bb652048291558c6c > Cr-Commit-Position: refs/heads/master@{#324023} TBR=bashi@chromium.org,ksakamoto@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464780 Committed: https://crrev.com/2a0977c4c2dfa7614f1e0eea3d0f0c21937565b3 Cr-Commit-Position: refs/heads/master@{#324046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -131 lines) Patch
M third_party/ots/README.chromium View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/ots/include/opentype-sanitiser.h View 6 chunks +49 lines, -17 lines 0 comments Download
M third_party/ots/src/cmap.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/ots/src/os2.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/ots/src/os2.cc View 10 chunks +46 lines, -83 lines 0 comments Download
M third_party/ots/src/ots.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M third_party/ots/src/woff2.cc View 5 chunks +20 lines, -16 lines 0 comments Download
M third_party/ots/test/ot-sanitise.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/ots/test/side-by-side.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zhaoqin1
Created Revert of Update OTS to revision 6d2e08b
5 years, 8 months ago (2015-04-07 15:25:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064913002/1
5 years, 8 months ago (2015-04-07 15:26:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 15:27:15 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 15:27:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a0977c4c2dfa7614f1e0eea3d0f0c21937565b3
Cr-Commit-Position: refs/heads/master@{#324046}

Powered by Google App Engine
This is Rietveld 408576698