Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1064903003: Re-land: C++ readability review (Closed)

Created:
5 years, 8 months ago by Chirantan Ekbote
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chirantan+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: C++ readability review BUG=b/18275087 Committed: https://crrev.com/9244d4429f05c60266d2e527996cde78f90dc0dc Cr-Commit-Position: refs/heads/master@{#324112}

Patch Set 1 : Original CL #

Patch Set 2 : Skip tests if not supported #

Unified diffs Side-by-side diffs Delta from patch set Stats (+816 lines, -705 lines) Patch
M components/gcm_driver/gcm_driver_desktop.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/timers.gypi View 1 chunk +3 lines, -5 lines 0 comments Download
M components/timers/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
D components/timers/alarm_timer.h View 1 chunk +0 lines, -105 lines 0 comments Download
D components/timers/alarm_timer.cc View 1 chunk +0 lines, -127 lines 0 comments Download
A components/timers/alarm_timer_chromeos.h View 1 chunk +146 lines, -0 lines 0 comments Download
A components/timers/alarm_timer_chromeos.cc View 1 chunk +466 lines, -0 lines 0 comments Download
M components/timers/alarm_timer_unittest.cc View 1 19 chunks +197 lines, -181 lines 0 comments Download
D components/timers/rtc_alarm.h View 1 chunk +0 lines, -95 lines 0 comments Download
D components/timers/rtc_alarm.cc View 1 chunk +0 lines, -186 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Chirantan Ekbote
PTAL. This CL was reverted because it caused some AlarmTimer unittests to fail on the ...
5 years, 8 months ago (2015-04-07 19:10:51 UTC) #2
Daniel Erat
lgtm for the update
5 years, 8 months ago (2015-04-07 19:15:50 UTC) #3
Nicolas Zea
lgtm
5 years, 8 months ago (2015-04-07 19:21:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064903003/20001
5 years, 8 months ago (2015-04-07 20:05:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 20:43:25 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 20:44:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9244d4429f05c60266d2e527996cde78f90dc0dc
Cr-Commit-Position: refs/heads/master@{#324112}

Powered by Google App Engine
This is Rietveld 408576698