Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: remoting/protocol/fake_datagram_socket.cc

Issue 1064863004: Use base::ResetAndReturn() in remoting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/fake_datagram_socket.cc
diff --git a/remoting/protocol/fake_datagram_socket.cc b/remoting/protocol/fake_datagram_socket.cc
index 75a50b39a74af4b0b4c315443877a0c7c683168a..9bd4ede48b336e0356aebfa8b7342676f68dd1cc 100644
--- a/remoting/protocol/fake_datagram_socket.cc
+++ b/remoting/protocol/fake_datagram_socket.cc
@@ -5,6 +5,7 @@
#include "remoting/protocol/fake_datagram_socket.h"
#include "base/bind.h"
+#include "base/callback_helpers.h"
#include "base/single_thread_task_runner.h"
#include "base/thread_task_runner_handle.h"
#include "net/base/address_list.h"
@@ -36,9 +37,7 @@ void FakeDatagramSocket::AppendInputPacket(const std::string& data) {
int result = CopyReadData(read_buffer_.get(), read_buffer_size_);
read_buffer_ = nullptr;
- net::CompletionCallback callback = read_callback_;
- read_callback_.Reset();
- callback.Run(result);
+ base::ResetAndReturn(&read_callback_).Run(result);
}
}

Powered by Google App Engine
This is Rietveld 408576698