Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1064863004: Use base::ResetAndReturn() in remoting. (Closed)

Created:
5 years, 8 months ago by Sergey Ulanov
Modified:
5 years, 8 months ago
Reviewers:
Wez, dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::ResetAndReturn() in remoting. base::ResetAndReturn() makes code shorter and simpler. Also in several places callbacks were Reset() after Run(), which is dangerous for callback that are allowed to delete the caller. base::ResetAndReturn() helps to avoid this issue. Committed: https://crrev.com/d9bdcb6c95619e6cb3a4281156573c58f7626a26 Cr-Commit-Position: refs/heads/master@{#326940}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -90 lines) Patch
M remoting/client/plugin/chromoting_instance.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/token_fetcher_proxy.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/daemon_process.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/host/dns_blackhole_checker.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/heartbeat_sender.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/register_support_host_request.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_mac.mm View 2 chunks +4 lines, -5 lines 0 comments Download
M remoting/host/setup/host_starter.cc View 5 chunks +9 lines, -16 lines 0 comments Download
M remoting/host/setup/oauth_client.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/protocol/fake_authenticator.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/protocol/fake_datagram_socket.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator.cc View 1 2 chunks +3 lines, -10 lines 0 comments Download
M remoting/protocol/third_party_authenticator_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M remoting/signaling/iq_sender.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M remoting/test/access_token_fetcher.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M remoting/test/remote_host_info_fetcher.cc View 5 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Sergey Ulanov
5 years, 8 months ago (2015-04-24 18:58:53 UTC) #2
Wez
lgtm https://codereview.chromium.org/1064863004/diff/1/remoting/host/dns_blackhole_checker.cc File remoting/host/dns_blackhole_checker.cc (right): https://codereview.chromium.org/1064863004/diff/1/remoting/host/dns_blackhole_checker.cc#newcode44 remoting/host/dns_blackhole_checker.cc:44: nit: No need for this blank line
5 years, 8 months ago (2015-04-24 23:02:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064863004/1
5 years, 8 months ago (2015-04-24 23:03:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/46513) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-24 23:07:27 UTC) #8
Sergey Ulanov
https://codereview.chromium.org/1064863004/diff/1/remoting/host/dns_blackhole_checker.cc File remoting/host/dns_blackhole_checker.cc (right): https://codereview.chromium.org/1064863004/diff/1/remoting/host/dns_blackhole_checker.cc#newcode44 remoting/host/dns_blackhole_checker.cc:44: On 2015/04/24 23:02:31, Wez wrote: > nit: No need ...
5 years, 8 months ago (2015-04-24 23:30:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064863004/20001
5 years, 8 months ago (2015-04-24 23:30:19 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-25 00:18:25 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 00:19:24 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d9bdcb6c95619e6cb3a4281156573c58f7626a26
Cr-Commit-Position: refs/heads/master@{#326940}

Powered by Google App Engine
This is Rietveld 408576698