Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1064863002: Fix data fetcher for light stop correctly on windows. (Closed)

Created:
5 years, 8 months ago by riju_
Modified:
5 years, 8 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, Michael van Ouwerkerk, jam, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix data fetcher for light stop correctly on windows. SetBufferAvailableState was from called DataFetcherSharedMemory::Stop for all cases including TYPE_LIGHT, but for light, we are not using it as we are using SetLightBuffer(light_buffer_, -1); BUG=474586 Committed: https://crrev.com/829dac44a4363a7502dba6344407a7f26e64b7aa Cr-Commit-Position: refs/heads/master@{#324044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/device_sensors/data_fetcher_shared_memory_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
riju_
Hi Tim, while adding the layout tests in https://codereview.chromium.org/490773003/, I saw that the win_blink_rel was ...
5 years, 8 months ago (2015-04-07 13:49:25 UTC) #2
timvolodine
On 2015/04/07 13:49:25, riju_ wrote: > Hi Tim, > while adding the layout tests in ...
5 years, 8 months ago (2015-04-07 14:02:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064863002/1
5 years, 8 months ago (2015-04-07 14:36:45 UTC) #5
riju_
On 2015/04/07 14:02:45, timvolodine wrote: > On 2015/04/07 13:49:25, riju_ wrote: > > Hi Tim, ...
5 years, 8 months ago (2015-04-07 14:36:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 15:19:55 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 15:21:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/829dac44a4363a7502dba6344407a7f26e64b7aa
Cr-Commit-Position: refs/heads/master@{#324044}

Powered by Google App Engine
This is Rietveld 408576698