Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1064853002: Speculative attempt to unflake inspector/console/console-native-function.html (Closed)

Created:
5 years, 8 months ago by pfeldman
Modified:
5 years, 8 months ago
Reviewers:
sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Speculative attempt to unflake inspector/console/console-native-function.html BUG=474422 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193393

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/console-test.js View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/inspector-test.js View 2 chunks +10 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
pfeldman
5 years, 8 months ago (2015-04-07 10:18:41 UTC) #2
sergeyv
https://codereview.chromium.org/1064853002/diff/1/LayoutTests/http/tests/inspector/inspector-test.js File LayoutTests/http/tests/inspector/inspector-test.js (right): https://codereview.chromium.org/1064853002/diff/1/LayoutTests/http/tests/inspector/inspector-test.js#newcode857 LayoutTests/http/tests/inspector/inspector-test.js:857: for (var moduleName of InspectorTest._modulesToPreload) should we merge modulesToPreload ...
5 years, 8 months ago (2015-04-08 09:47:33 UTC) #3
sergeyv
lgtm
5 years, 8 months ago (2015-04-08 10:11:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064853002/1
5 years, 8 months ago (2015-04-08 17:44:34 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 23:23:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193393

Powered by Google App Engine
This is Rietveld 408576698