Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1064843003: Add an UMA stat to be able to see if the User pods are show on start screen, (Closed)

Created:
5 years, 8 months ago by Ivan Podogov
Modified:
5 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an UMA stat to be able to see if the User pods are show on start screen, and if not, what disabled them: the local setting or domain policy. BUG=470383 Committed: https://crrev.com/46bbbcd70fbf85d2624ad0a4b678255efa9fe5e9 Cr-Commit-Position: refs/heads/master@{#324206}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M chrome/browser/chromeos/login/session/user_session_manager.h View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 3 chunks +27 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ivan Podogov
PTAL
5 years, 8 months ago (2015-04-07 14:18:46 UTC) #2
Dmitry Polukhin
lgtm
5 years, 8 months ago (2015-04-07 14:20:07 UTC) #3
Ilya Sherman
lgtm https://codereview.chromium.org/1064843003/diff/1/chrome/browser/chromeos/login/session/user_session_manager.cc File chrome/browser/chromeos/login/session/user_session_manager.cc (right): https://codereview.chromium.org/1064843003/diff/1/chrome/browser/chromeos/login/session/user_session_manager.cc#newcode13 chrome/browser/chromeos/login/session/user_session_manager.cc:13: #include "base/metrics/histogram.h" nit: Please include histogram_macros instead
5 years, 8 months ago (2015-04-07 21:31:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064843003/20001
5 years, 8 months ago (2015-04-08 08:05:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 10:02:34 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 10:03:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46bbbcd70fbf85d2624ad0a4b678255efa9fe5e9
Cr-Commit-Position: refs/heads/master@{#324206}

Powered by Google App Engine
This is Rietveld 408576698