Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 106483002: Remove WTF::textAtom and WTF::commentAtom (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove WTF::textAtom and WTF::commentAtom These are only used in implementations of Node::nodeName(), where CDATASection, Document and DocumentFragment already use raw strings. Added in <https://trac.webkit.org/changeset/9639>;, at which point both atoms were used in multiple places. Previously raw strings were used. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M Source/core/dom/Comment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/AtomicString.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/wtf/text/StringStatics.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
7 years ago (2013-12-05 12:55:56 UTC) #1
jochen (gone - plz use gerrit)
why did you chose to remove the atomic strings here instead of adding them in ...
7 years ago (2013-12-05 13:00:16 UTC) #2
philipj_slow
On 2013/12/05 13:00:16, jochen wrote: > why did you chose to remove the atomic strings ...
7 years ago (2013-12-05 13:17:53 UTC) #3
jochen (gone - plz use gerrit)
no, trusting the perf bots is fine lgtm
7 years ago (2013-12-05 14:44:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/106483002/1
7 years ago (2013-12-05 14:52:36 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=19676
7 years ago (2013-12-05 18:11:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/106483002/1
7 years ago (2013-12-05 18:37:39 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-05 19:28:42 UTC) #8
Message was sent while issue was closed.
Change committed as 163281

Powered by Google App Engine
This is Rietveld 408576698