Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/favicon/core/BUILD.gn

Issue 1064823002: Componentize FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon-notification
Patch Set: Rebase and address comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/favicon.gypi ('K') | « components/favicon/content/content_favicon_driver.cc ('k') | components/favicon/core/favicon_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/BUILD.gn
diff --git a/components/favicon/core/BUILD.gn b/components/favicon/core/BUILD.gn
index 4ac4750ae34e93742868d12f3b294800c937efe0..95e15b4da1513cf5cd7b2e6883e0ec32a214978a 100644
--- a/components/favicon/core/BUILD.gn
+++ b/components/favicon/core/BUILD.gn
@@ -9,6 +9,8 @@ static_library("core") {
"fallback_icon_service.h",
"favicon_client.h",
"favicon_driver.h",
+ "favicon_driver_impl.cc",
+ "favicon_driver_impl.h",
"favicon_driver_observer.h",
"favicon_handler.cc",
"favicon_handler.h",
@@ -24,6 +26,7 @@ static_library("core") {
"//components/history/core/browser",
"//components/keyed_service/core",
"//skia",
+ "//ui/base",
"//ui/gfx",
"//url",
]
« components/favicon.gypi ('K') | « components/favicon/content/content_favicon_driver.cc ('k') | components/favicon/core/favicon_driver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698