Componentize FaviconTabHelper

chrome/browser/favicon/favicon_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/favicon/core/favicon_handler.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/favicon/chrome_favicon_client_factory.h"
 #include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
@@ skipping 165 matching lines @@
 class TestFaviconDriver : public favicon::FaviconDriver {
  public:
   TestFaviconDriver()
       : favicon_validity_(false),
         num_active_favicon_(0),
         num_favicon_available_(0),
         update_active_favicon_(false) {}
 
   ~TestFaviconDriver() override {}
 
+  // favicon::FaviconDriver implementation.
+  void FetchFavicon(const GURL& url) override {
+    ADD_FAILURE() << "TestFaviconDriver::FetchFavicon() "
+                  << "should never be called in tests.";
+  }
+
+  void SaveFavicon() override {
+    ADD_FAILURE() << "TestFaviconDriver::SaveFavicon() "
+                  << "should never be called in tests.";
+  }
+
+  gfx::Image GetFavicon() const override {
+    ADD_FAILURE() << "TestFaviconDriver::GetFavicon() "
+                  << "should never be called in tests.";
+    return gfx::Image();
+  }
+
+  bool FaviconIsValid() const override {
+    ADD_FAILURE() << "TestFaviconDriver::FaviconIsValid() "
+                  << "should never be called in tests.";
+    return false;
+  }
+
+  bool HasPendingTasksForTest() override {
+    ADD_FAILURE() << "TestFaviconDriver::HasPendingTasksForTest() "
+                  << "should never be called in tests.";
+    return false;
+  }
+
   int StartDownload(const GURL& url, int max_bitmap_size) override {
     ADD_FAILURE() << "TestFaviconDriver::StartDownload() "
                   << "should never be called in tests.";
     return -1;
   }
 
   bool IsOffTheRecord() override { return false; }
 
   bool IsBookmarked(const GURL& url) override { return false; }
 
@@ skipping 28 matching lines @@
     update_active_favicon_ = update_active_favicon;
     if (!update_active_favicon)
       return;
 
     ++num_active_favicon_;
     SetActiveFaviconURL(icon_url);
     SetActiveFaviconValidity(true);
     SetActiveFaviconImage(image);
   }
 
-  void NotifyFaviconUpdated(bool icon_url_changed) override {}
-
   size_t num_active_favicon() const { return num_active_favicon_; }
   size_t num_favicon_available() const { return num_favicon_available_; }
   void ResetNumActiveFavicon() { num_active_favicon_ = 0; }
   void ResetNumFaviconAvailable() { num_favicon_available_ = 0; }
 
   void SetActiveURL(GURL url) { url_ = url; }
 
   const gfx::Image available_favicon() { return available_image_; }
 
   const GURL available_icon_url() { return available_icon_url_; }
@@ skipping 1391 matching lines @@
   EXPECT_EQ(new_favicon_url, driver1.available_icon_url());
   EXPECT_FALSE(driver1.update_active_favicon());
   EXPECT_EQ(3u, driver1.num_favicon_available());
 }
 
 INSTANTIATE_TEST_CASE_P(FaviconHandlerTestActiveFaviconValidityTrueOrFalse,
                         FaviconHandlerActiveFaviconValidityParamTest,
                         ::testing::Bool());
 
 }  // namespace.