components/favicon/core/BUILD.gn - Issue 1064823002: Componentize FaviconTabHelper

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/favicon/core/BUILD.gn

Issue 1064823002: Componentize FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon-notification

Patch Set: Fix BUILD.gn Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 static_library("core") {	5 static_library("core") {

6 sources = [	6 sources = [

7 "fallback_icon_client.h",	7 "fallback_icon_client.h",

8 "fallback_icon_service.cc",	8 "fallback_icon_service.cc",

9 "fallback_icon_service.h",	9 "fallback_icon_service.h",

10 "favicon_client.h",	10 "favicon_client.h",

	11 "favicon_driver.cc",

11 "favicon_driver.h",	12 "favicon_driver.h",

	13 "favicon_driver_impl.cc",

	14 "favicon_driver_impl.h",

12 "favicon_driver_observer.h",	15 "favicon_driver_observer.h",

13 "favicon_handler.cc",	16 "favicon_handler.cc",

14 "favicon_handler.h",	17 "favicon_handler.h",

15 "favicon_service.cc",	18 "favicon_service.cc",

16 "favicon_service.h",	19 "favicon_service.h",

17 "favicon_url.cc",	20 "favicon_url.cc",

18 "favicon_url.h",	21 "favicon_url.h",

19 ]	22 ]

20	23

21 deps = [	24 deps = [

	25 "//base",

22 "//components/bookmarks/browser",	26 "//components/bookmarks/browser",

23 "//components/favicon_base",	27 "//components/favicon_base",

24 "//components/history/core/browser",	28 "//components/history/core/browser",

25 "//components/keyed_service/core",	29 "//components/keyed_service/core",

26 "//skia",	30 "//skia",

	31 "//ui/base",

27 "//ui/gfx",	32 "//ui/gfx",

28 "//url",	33 "//url",

29 ]	34 ]

30 }	35 }

OLD	NEW

« no previous file with comments | « components/favicon/content/content_favicon_driver.cc ('k') | components/favicon/core/favicon_driver.h » ('j') | no next file with comments »