Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: components/favicon.gypi

Issue 1064823002: Componentize FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon-notification
Patch Set: Fix BUILD.gn Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc ('k') | components/favicon/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/favicon/core 8 # GN version: //components/favicon/core
9 'target_name': 'favicon_core', 9 'target_name': 'favicon_core',
10 'type': 'static_library', 10 'type': 'static_library',
11 'dependencies': [ 11 'dependencies': [
12 '../base/base.gyp:base',
12 '../skia/skia.gyp:skia', 13 '../skia/skia.gyp:skia',
14 '../ui/base/ui_base.gyp:ui_base',
13 '../ui/gfx/gfx.gyp:gfx', 15 '../ui/gfx/gfx.gyp:gfx',
14 '../url/url.gyp:url_lib', 16 '../url/url.gyp:url_lib',
15 'bookmarks_browser', 17 'bookmarks_browser',
16 'favicon_base', 18 'favicon_base',
17 'history_core_browser', 19 'history_core_browser',
18 'keyed_service_core', 20 'keyed_service_core',
19 ], 21 ],
20 'sources': [ 22 'sources': [
21 # Note: sources list duplicated in GN build. 23 # Note: sources list duplicated in GN build.
22 'favicon/core/fallback_icon_client.h', 24 'favicon/core/fallback_icon_client.h',
23 'favicon/core/fallback_icon_service.cc', 25 'favicon/core/fallback_icon_service.cc',
24 'favicon/core/fallback_icon_service.h', 26 'favicon/core/fallback_icon_service.h',
25 'favicon/core/favicon_client.h', 27 'favicon/core/favicon_client.h',
28 'favicon/core/favicon_driver.cc',
26 'favicon/core/favicon_driver.h', 29 'favicon/core/favicon_driver.h',
30 'favicon/core/favicon_driver_impl.cc',
31 'favicon/core/favicon_driver_impl.h',
27 'favicon/core/favicon_driver_observer.h', 32 'favicon/core/favicon_driver_observer.h',
28 'favicon/core/favicon_handler.cc', 33 'favicon/core/favicon_handler.cc',
29 'favicon/core/favicon_handler.h', 34 'favicon/core/favicon_handler.h',
30 'favicon/core/favicon_service.cc', 35 'favicon/core/favicon_service.cc',
31 'favicon/core/favicon_service.h', 36 'favicon/core/favicon_service.h',
32 'favicon/core/favicon_url.cc', 37 'favicon/core/favicon_url.cc',
33 'favicon/core/favicon_url.h', 38 'favicon/core/favicon_url.h',
34 ], 39 ],
35 'include_dirs': [ 40 'include_dirs': [
36 '..', 41 '..',
37 ], 42 ],
38 }, 43 },
39 ], 44 ],
40 'conditions': [ 45 'conditions': [
41 ['OS!="ios"', { 46 ['OS!="ios"', {
42 'targets': [ 47 'targets': [
43 { 48 {
44 # GN version: //components/favicon/content 49 # GN version: //components/favicon/content
45 'target_name': 'favicon_content', 50 'target_name': 'favicon_content',
46 'type': 'static_library', 51 'type': 'static_library',
47 'dependencies': [ 52 'dependencies': [
53 '../base/base.gyp:base',
48 '../content/content.gyp:content_browser', 54 '../content/content.gyp:content_browser',
49 '../content/content.gyp:content_common', 55 '../content/content.gyp:content_common',
56 '../ui/gfx/gfx.gyp:gfx',
50 'favicon_base', 57 'favicon_base',
51 'favicon_core', 58 'favicon_core',
52 ], 59 ],
53 'sources': [ 60 'sources': [
54 # Note: sources list duplicated in GN build. 61 # Note: sources list duplicated in GN build.
62 'favicon/content/content_favicon_driver.cc',
63 'favicon/content/content_favicon_driver.h',
55 'favicon/content/favicon_url_util.cc', 64 'favicon/content/favicon_url_util.cc',
56 'favicon/content/favicon_url_util.h', 65 'favicon/content/favicon_url_util.h',
57 ], 66 ],
58 'include_dirs': [ 67 'include_dirs': [
59 '..', 68 '..',
60 ], 69 ],
61 }, 70 },
62 ], 71 ],
63 }], 72 }],
64 ['OS=="ios"', { 73 ['OS=="ios"', {
65 'targets': [ 74 'targets': [
66 { 75 {
67 'target_name': 'favicon_ios', 76 'target_name': 'favicon_ios',
68 'type': 'static_library', 77 'type': 'static_library',
69 'dependencies': [ 78 'dependencies': [
79 '../base/base.gyp:base',
70 '../ios/web/ios_web.gyp:ios_web', 80 '../ios/web/ios_web.gyp:ios_web',
81 '../ui/gfx/gfx.gyp:gfx',
71 'favicon_base', 82 'favicon_base',
72 'favicon_core', 83 'favicon_core',
73 ], 84 ],
74 'sources': [ 85 'sources': [
86 'favicon/ios/favicon_url_util.cc',
75 'favicon/ios/favicon_url_util.h', 87 'favicon/ios/favicon_url_util.h',
76 'favicon/ios/favicon_url_util.cc', 88 'favicon/ios/web_favicon_driver.cc',
89 'favicon/ios/web_favicon_driver.h',
77 ], 90 ],
78 'include_dirs': [ 91 'include_dirs': [
79 '..', 92 '..',
80 ], 93 ],
81 }, 94 },
82 ], 95 ],
83 }], 96 }],
84 ], 97 ],
85 } 98 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc ('k') | components/favicon/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698