Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Side by Side Diff: components/favicon.gypi

Issue 1064823002: Componentize FaviconTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon-notification
Patch Set: Rebase and address comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc ('k') | components/favicon/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/favicon/core 8 # GN version: //components/favicon/core
9 'target_name': 'favicon_core', 9 'target_name': 'favicon_core',
10 'type': 'static_library', 10 'type': 'static_library',
11 'dependencies': [ 11 'dependencies': [
12 '../skia/skia.gyp:skia', 12 '../skia/skia.gyp:skia',
13 '../ui/base/ui_base.gyp:ui_base',
13 '../ui/gfx/gfx.gyp:gfx', 14 '../ui/gfx/gfx.gyp:gfx',
14 '../url/url.gyp:url_lib', 15 '../url/url.gyp:url_lib',
15 'bookmarks_browser', 16 'bookmarks_browser',
16 'favicon_base', 17 'favicon_base',
17 'history_core_browser', 18 'history_core_browser',
18 'keyed_service_core', 19 'keyed_service_core',
19 ], 20 ],
20 'sources': [ 21 'sources': [
21 # Note: sources list duplicated in GN build. 22 # Note: sources list duplicated in GN build.
22 'favicon/core/fallback_icon_client.h', 23 'favicon/core/fallback_icon_client.h',
23 'favicon/core/fallback_icon_service.cc', 24 'favicon/core/fallback_icon_service.cc',
24 'favicon/core/fallback_icon_service.h', 25 'favicon/core/fallback_icon_service.h',
25 'favicon/core/favicon_client.h', 26 'favicon/core/favicon_client.h',
27 'favicon/core/favicon_driver.cc',
26 'favicon/core/favicon_driver.h', 28 'favicon/core/favicon_driver.h',
29 'favicon/core/favicon_driver_impl.cc',
30 'favicon/core/favicon_driver_impl.h',
27 'favicon/core/favicon_driver_observer.h', 31 'favicon/core/favicon_driver_observer.h',
28 'favicon/core/favicon_handler.cc', 32 'favicon/core/favicon_handler.cc',
29 'favicon/core/favicon_handler.h', 33 'favicon/core/favicon_handler.h',
30 'favicon/core/favicon_service.cc', 34 'favicon/core/favicon_service.cc',
31 'favicon/core/favicon_service.h', 35 'favicon/core/favicon_service.h',
32 'favicon/core/favicon_url.cc', 36 'favicon/core/favicon_url.cc',
33 'favicon/core/favicon_url.h', 37 'favicon/core/favicon_url.h',
34 ], 38 ],
35 'include_dirs': [ 39 'include_dirs': [
36 '..', 40 '..',
37 ], 41 ],
38 }, 42 },
39 ], 43 ],
40 'conditions': [ 44 'conditions': [
41 ['OS!="ios"', { 45 ['OS!="ios"', {
42 'targets': [ 46 'targets': [
43 { 47 {
44 # GN version: //components/favicon/content 48 # GN version: //components/favicon/content
45 'target_name': 'favicon_content', 49 'target_name': 'favicon_content',
46 'type': 'static_library', 50 'type': 'static_library',
47 'dependencies': [ 51 'dependencies': [
48 '../content/content.gyp:content_browser', 52 '../content/content.gyp:content_browser',
49 '../content/content.gyp:content_common', 53 '../content/content.gyp:content_common',
50 'favicon_base', 54 'favicon_base',
51 'favicon_core', 55 'favicon_core',
52 ], 56 ],
53 'sources': [ 57 'sources': [
54 # Note: sources list duplicated in GN build. 58 # Note: sources list duplicated in GN build.
59 'favicon/content/content_favicon_driver.cc',
60 'favicon/content/content_favicon_driver.h',
55 'favicon/content/favicon_url_util.cc', 61 'favicon/content/favicon_url_util.cc',
56 'favicon/content/favicon_url_util.h', 62 'favicon/content/favicon_url_util.h',
57 ], 63 ],
58 'include_dirs': [ 64 'include_dirs': [
59 '..', 65 '..',
60 ], 66 ],
61 }, 67 },
62 ], 68 ],
63 }], 69 }],
64 ['OS=="ios"', { 70 ['OS=="ios"', {
65 'targets': [ 71 'targets': [
66 { 72 {
67 'target_name': 'favicon_ios', 73 'target_name': 'favicon_ios',
68 'type': 'static_library', 74 'type': 'static_library',
69 'dependencies': [ 75 'dependencies': [
70 '../ios/web/ios_web.gyp:ios_web', 76 '../ios/web/ios_web.gyp:ios_web',
71 'favicon_base', 77 'favicon_base',
72 'favicon_core', 78 'favicon_core',
droger 2015/04/08 09:31:58 Your new file depends on base and ui/gfx.
73 ], 79 ],
74 'sources': [ 80 'sources': [
81 'favicon/ios/favicon_url_util.cc',
75 'favicon/ios/favicon_url_util.h', 82 'favicon/ios/favicon_url_util.h',
76 'favicon/ios/favicon_url_util.cc', 83 'favicon/ios/web_favicon_driver.cc',
84 'favicon/ios/web_favicon_driver.h',
77 ], 85 ],
78 'include_dirs': [ 86 'include_dirs': [
79 '..', 87 '..',
80 ], 88 ],
81 }, 89 },
82 ], 90 ],
83 }], 91 }],
84 ], 92 ],
85 } 93 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc ('k') | components/favicon/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698