DescriptionFix OutOfMemoryDeathTest.ViaSharedLibraries.
This test was invalid on modern glibc:
asprintf errors EOVERFLOW without attempting an allocation
when the size is at least INT_MAX - 32. INT_MAX - 33 is the
largest size that can attempt to trigger allocation failure,
and will not necessarily accomplish that on some systems.
Create a library that is specified to wrap malloc trivially,
to accomplish the goal of the test without external dependencies
or inconsistently implemented behavior.
BUG=428211
Committed: https://crrev.com/9a4f22dbb7266733c40a632ece2ddc7eaf56e6ac
Cr-Commit-Position: refs/heads/master@{#324092}
Patch Set 1 #Patch Set 2 : Rejigger malloc_wrapper gyp target to always have a 'target name' key. #Patch Set 3 : Move the gyp conditional to the top level #Patch Set 4 : Original CL from https://codereview.chromium.org/878473002/ #Patch Set 5 : Fixed CL to avoid target enumeration on unsupported OS #
Messages
Total messages: 13 (3 generated)
|