Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1064793002: Fix OutOfMemoryDeathTest.ViaSharedLibraries. (Closed)

Created:
5 years, 8 months ago by Ian Coolidge
Modified:
5 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gunsch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix OutOfMemoryDeathTest.ViaSharedLibraries. This test was invalid on modern glibc: asprintf errors EOVERFLOW without attempting an allocation when the size is at least INT_MAX - 32. INT_MAX - 33 is the largest size that can attempt to trigger allocation failure, and will not necessarily accomplish that on some systems. Create a library that is specified to wrap malloc trivially, to accomplish the goal of the test without external dependencies or inconsistently implemented behavior. BUG=428211 Committed: https://crrev.com/9a4f22dbb7266733c40a632ece2ddc7eaf56e6ac Cr-Commit-Position: refs/heads/master@{#324092}

Patch Set 1 #

Patch Set 2 : Rejigger malloc_wrapper gyp target to always have a 'target name' key. #

Patch Set 3 : Move the gyp conditional to the top level #

Patch Set 4 : Original CL from https://codereview.chromium.org/878473002/ #

Patch Set 5 : Fixed CL to avoid target enumeration on unsupported OS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -16 lines) Patch
M base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M base/base.gyp View 1 2 4 2 chunks +25 lines, -5 lines 0 comments Download
M base/base_unittests.isolate View 1 chunk +7 lines, -0 lines 0 comments Download
M base/process/memory_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M base/test/BUILD.gn View 4 1 chunk +12 lines, -0 lines 0 comments Download
A base/test/malloc_wrapper.h View 1 chunk +21 lines, -0 lines 0 comments Download
A + base/test/malloc_wrapper.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Ian Coolidge
PTAL. mfomitchev perhaps you can give me some help verifying that I don't break the ...
5 years, 8 months ago (2015-04-07 06:43:55 UTC) #2
Scott Hess - ex-Googler
LGTM. I don't see how this could POSSIBLY break iOS! I see that the previous ...
5 years, 8 months ago (2015-04-07 17:25:47 UTC) #3
mfomitchev
On 2015/04/07 06:43:55, Ian Coolidge wrote: > PTAL. mfomitchev perhaps you can give me some ...
5 years, 8 months ago (2015-04-07 17:34:52 UTC) #4
Scott Hess - ex-Googler
On 2015/04/07 17:34:52, mfomitchev wrote: > On 2015/04/07 06:43:55, Ian Coolidge wrote: > > PTAL. ...
5 years, 8 months ago (2015-04-07 17:37:58 UTC) #5
danakj
can you summarize the diff vs the last patch set? (uploading as a new patch ...
5 years, 8 months ago (2015-04-07 18:02:48 UTC) #6
Ian Coolidge
Uploaded older patch set as 4, and re-uploaded new patch set as 5, so differences ...
5 years, 8 months ago (2015-04-07 18:18:44 UTC) #7
danakj
LGTM
5 years, 8 months ago (2015-04-07 18:21:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064793002/80001
5 years, 8 months ago (2015-04-07 18:23:14 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-07 19:28:22 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 19:30:07 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9a4f22dbb7266733c40a632ece2ddc7eaf56e6ac
Cr-Commit-Position: refs/heads/master@{#324092}

Powered by Google App Engine
This is Rietveld 408576698