Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/dom/scripts/css_code_generator.py

Issue 1064783002: CssStyleDeclaration performance work (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/css_code_generator.py
diff --git a/tools/dom/scripts/css_code_generator.py b/tools/dom/scripts/css_code_generator.py
index a290c5fc83d1a253765fe5df0c465876cc127fd1..6b07534024522d85f5790970a02c0aa10b5e9304 100644
--- a/tools/dom/scripts/css_code_generator.py
+++ b/tools/dom/scripts/css_code_generator.py
@@ -117,14 +117,34 @@ $endif
@DomName('CSSStyleDeclaration.setProperty')
void setProperty(String propertyName, String value, [String priority]) {
+ return _setPropertyHelper(_browserPropertyName(propertyName),
+ value, priority);
+ }
+
+ String _browserPropertyName(String propertyName) {
+ String name = _readCache(propertyName);
+ if (name is String) return name;
if (_supportsProperty(_camelCase(propertyName))) {
- return _setPropertyHelper(propertyName, value, priority);
+ name = propertyName;
} else {
- return _setPropertyHelper(Device.cssPrefix + propertyName, value,
- priority);
+ name = Device.cssPrefix + propertyName;
}
+ _writeCache(propertyName, name);
+ return name;
}
+$if DART2JS
+ static final _propertyCache = JS('', '{}');
+ static String _readCache(String key) =>
+ JS('String|Null', '#[#]', _propertyCache, key);
+ static void _writeCache(String key, String value) {
+ JS('void', '#[#] = #', _propertyCache, key, value);
+ }
+$else
+ static String _readCache(String key) => null;
+ static void _writeCache(String key, value) {}
+$endif
+
static String _camelCase(String hyphenated) {
$if DART2JS
var replacedMs = JS('String', r'#.replace(/^-ms-/, "ms-")', hyphenated);
@@ -142,18 +162,9 @@ $endif
$if DART2JS
void _setPropertyHelper(String propertyName, String value, [String priority]) {
- // try/catch for IE9 which throws on unsupported values.
- try {
- if (value == null) value = '';
- if (priority == null) {
- priority = '';
- }
- JS('void', '#.setProperty(#, #, #)', this, propertyName, value, priority);
- // Bug #2772, IE9 requires a poke to actually apply the value.
- if (JS('bool', '!!#.setAttribute', this)) {
- JS('void', '#.setAttribute(#, #)', this, propertyName, value);
- }
- } catch (e) {}
+ if (value == null) value = '';
+ if (priority == null) priority = '';
+ JS('void', '#.setProperty(#, #, #)', this, propertyName, value, priority);
}
/**
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698