Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1064773002: Disable Occlusion Query on MediaTek MT8135 (Closed)

Created:
5 years, 8 months ago by mckev
Modified:
5 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, vmiura, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Occlusion Query on MediaTek MT8135 Devices with some versions of the MediaTek MT8135 GPU driver do not return values when an occlusion query is performed, which causes a hard CHECK to get hit in GLES2Implementation::GetQueryObjectuivEXT. This adds an entry to the GPU bug list for this device (which identifies as PowerVR Rogue Han), preventing occlusion queries from being used on affected devices and driver versions. BUG=474413 TEST=OcclusionQuery.Occlusion Committed: https://crrev.com/0b011504b5d210b45ab543d3646abb4f563f2ee8 Cr-Commit-Position: refs/heads/master@{#324072}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
mckev
Hi Ken, PTAL! :-)
5 years, 8 months ago (2015-04-07 01:09:46 UTC) #3
Ken Russell (switch to Gerrit)
That's unfortunate. LGTM. Thanks for the workaround. +a few others as FYI.
5 years, 8 months ago (2015-04-07 02:15:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064773002/20001
5 years, 8 months ago (2015-04-07 16:22:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/40440) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-07 16:28:11 UTC) #8
David Yen
https://codereview.chromium.org/1064773002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/1064773002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "7.18", I believe this file is out of ...
5 years, 8 months ago (2015-04-07 16:33:10 UTC) #10
mckev
On 2015/04/07 16:33:10, David Yen wrote: > https://codereview.chromium.org/1064773002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc > File gpu/config/gpu_driver_bug_list_json.cc (right): > > https://codereview.chromium.org/1064773002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 ...
5 years, 8 months ago (2015-04-07 16:33:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064773002/40001
5 years, 8 months ago (2015-04-07 16:33:44 UTC) #14
David Yen
On 2015/04/07 16:33:44, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-07 16:34:34 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-07 18:11:31 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 18:13:08 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b011504b5d210b45ab543d3646abb4f563f2ee8
Cr-Commit-Position: refs/heads/master@{#324072}

Powered by Google App Engine
This is Rietveld 408576698