views: Make SubmenuView::PaintChildren use the canvas via PaintRecorder

views: Make SubmenuView::PaintChildren use the canvas via PaintRecorder

This uses a PaintRecorder to get at the canvas() for painting, instead
of grabbing it directly off PaintContext. This will allow PaintContext
to be backed by a DisplayItemList instead of a Canvas.

R=sadrul, sky
BUG=466426
Committed: https://crrev.com/d2d3689d1c73e1573ce951e50510078f04c4efc0
Cr-Commit-Position: refs/heads/master@{#324080}

[danakj, 2015-04-06 23:59:26]

I think this is the last views site going through PaintContext.

[sadrul, 2015-04-07 18:49:01]

lgtm

https://codereview.chromium.org/1064763002/diff/20001/ui/views/controls/menu/...
File ui/views/controls/menu/submenu_view.cc (left):

https://codereview.chromium.org/1064763002/diff/20001/ui/views/controls/menu/...
ui/views/controls/menu/submenu_view.cc:195: PaintDropIndicator(context.canvas(),
drop_item_, drop_position_);
I assume PaintContext::canvas() will be removed so it can't be misused?

[danakj, 2015-04-07 18:49:25]

https://codereview.chromium.org/1064763002/diff/20001/ui/views/controls/menu/...
File ui/views/controls/menu/submenu_view.cc (left):

https://codereview.chromium.org/1064763002/diff/20001/ui/views/controls/menu/...
ui/views/controls/menu/submenu_view.cc:195: PaintDropIndicator(context.canvas(),
drop_item_, drop_position_);
On 2015/04/07 18:49:01, sadrul wrote:
> I assume PaintContext::canvas() will be removed so it can't be misused?

yep!

[danakj, 2015-04-07 18:49:30]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-04-07 18:49:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1064763002/20001

[commit-bot: I haz the power, 2015-04-07 18:55:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-07 18:57:50]

Patchset 2 (id:??) landed as
https://crrev.com/d2d3689d1c73e1573ce951e50510078f04c4efc0
Cr-Commit-Position: refs/heads/master@{#324080}