cc: Consider resolution when checking HigherPriorityTree.

cc: Consider resolution when checking HigherPriorityTree.

When we skip shared tiles in raster iterators, we need to ensure
that we consider resolution as a factor, since the twin will not be
returning tiles if they are of non-ideal resolution (so we shouldn't
be skipping the tile if the twin has higher, but non ideal, priority).

BUG=477136
R=sunnyps, vmiura

Committed: https://crrev.com/f54d5df0b2ae07ad224de8d52227ea925baca497
Cr-Commit-Position: refs/heads/master@{#325346}

[vmpstr, 2015-04-15 18:01:33]

vmpstr@chromium.org changed reviewers:
+ sunnyps@chromium.org, vmiura@chromium.org

[vmpstr, 2015-04-15 18:01:34]

Please take a look.

[sunnyps, 2015-04-15 19:18:46]

On 2015/04/15 18:01:34, vmpstr wrote:
> Please take a look.

I think the issue is fixed with this patch. Without this patch it's fairly easy
to reproduce the bug - I can get it to happen once every two attempts at
pinch-zoom in theverge.com. With this CL I haven't been able to reproduce the
issue.

[vmpstr, 2015-04-15 19:40:18]

vmpstr@chromium.org changed reviewers:
+ danakj@chromium.org, enne@chromium.org

[vmpstr, 2015-04-15 19:40:18]

+danakj, +enne, please take a look as well

[enne (OOO), 2015-04-15 20:16:00]

How does not sharing tiles affect this?

[vmpstr, 2015-04-15 20:40:38]

On 2015/04/15 20:16:00, enne wrote:
> How does not sharing tiles affect this?

It totally fixes it. :P This is a sharing tiles bug.

[vmpstr, 2015-04-15 20:41:33]

On 2015/04/15 20:40:38, vmpstr wrote:
> On 2015/04/15 20:16:00, enne wrote:
> > How does not sharing tiles affect this?
> 
> It totally fixes it. :P This is a sharing tiles bug.

To expand on this a bit, I would like to land this as a definite fix, since I'm
a bit less confident about unsharing and would like to do a few more tests
before trying to land.

[enne (OOO), 2015-04-15 20:47:02]

lgtm as a short-term solution

https://codereview.chromium.org/1064743003/diff/20001/cc/resources/raster_til...
File cc/resources/raster_tile_priority_queue_all.cc (right):

https://codereview.chromium.org/1064743003/diff/20001/cc/resources/raster_til...
cc/resources/raster_tile_priority_queue_all.cc:89: const Tile* active_tile =
shared_tile ? shared_tile : active_queue->Top();
Can you leave a comment about why you're doing this, here?

[vmpstr, 2015-04-15 21:05:25]

https://codereview.chromium.org/1064743003/diff/20001/cc/resources/raster_til...
File cc/resources/raster_tile_priority_queue_all.cc (right):

https://codereview.chromium.org/1064743003/diff/20001/cc/resources/raster_til...
cc/resources/raster_tile_priority_queue_all.cc:89: const Tile* active_tile =
shared_tile ? shared_tile : active_queue->Top();
On 2015/04/15 20:47:02, enne wrote:
> Can you leave a comment about why you're doing this, here?

Done.

[vmpstr, 2015-04-15 21:05:27]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2015-04-15 21:05:28]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1064743003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-04-15 21:06:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1064743003/40001

[commit-bot: I haz the power, 2015-04-15 23:42:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-15 23:44:50]

Patchset 3 (id:??) landed as
https://crrev.com/f54d5df0b2ae07ad224de8d52227ea925baca497
Cr-Commit-Position: refs/heads/master@{#325346}