Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1064723005: Remove support for specifying the number of available threads (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
Reviewers:
Yang
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove support for specifying the number of available threads The embedder can control how many threads it wants to use via the v8::Platform implementation. V8 internally doesn't spin up threads anymore. If the embedder doesn't want to use any threads at all, it's v8::Platform implementation must either run the background jobs on the foreground thread, or the embedder should specify --predictable BUG=none R=yangguo@chromium.org LOG=y Committed: https://crrev.com/47cca4684e18c928d5d32b290b4c1314ac156953 Cr-Commit-Position: refs/heads/master@{#27833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -26 lines) Patch
M include/v8.h View 2 chunks +10 lines, -4 lines 0 comments Download
M src/api.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -10 lines 0 comments Download
M src/optimizing-compile-dispatcher.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-14 15:06:40 UTC) #1
Yang
On 2015/04/14 15:06:40, jochen wrote: lgtm. Do I understand correctly that concurrency can be turned ...
5 years, 8 months ago (2015-04-15 06:37:52 UTC) #2
jochen (gone - plz use gerrit)
On 2015/04/15 at 06:37:52, yangguo wrote: > On 2015/04/14 15:06:40, jochen wrote: > > lgtm. ...
5 years, 8 months ago (2015-04-15 07:08:04 UTC) #3
jochen (gone - plz use gerrit)
updated the CL description to clarify this
5 years, 8 months ago (2015-04-15 07:09:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064723005/1
5 years, 8 months ago (2015-04-15 07:14:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 07:15:57 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/47cca4684e18c928d5d32b290b4c1314ac156953 Cr-Commit-Position: refs/heads/master@{#27833}
5 years, 8 months ago (2015-04-15 07:16:07 UTC) #8
Michael Achenbach
5 years, 8 months ago (2015-04-15 09:02:41 UTC) #9
Message was sent while issue was closed.
On 2015/04/15 07:16:07, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/47cca4684e18c928d5d32b290b4c1314ac156953
> Cr-Commit-Position: refs/heads/master@{#27833}

Is this possibly the reason for some timeouts and crashes in layout tests, e.g.
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3002
?

Powered by Google App Engine
This is Rietveld 408576698