Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1064713003: clang/win: Fix SecurityTest.CallocOverflow in -Os builds. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix SecurityTest.CallocOverflow in -Os builds. The additional indirection foils clang's efforts...for now. BUG=467929 Committed: https://crrev.com/d38072d64d9cf323642ca7212b8b25e340e3a985 Cr-Commit-Position: refs/heads/master@{#323978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/security_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
compilers 9_9
5 years, 8 months ago (2015-04-06 22:57:11 UTC) #2
Reid Kleckner
Looks terrible, please commit. :) (lgtm)
5 years, 8 months ago (2015-04-06 23:25:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064713003/1
5 years, 8 months ago (2015-04-06 23:26:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 23:30:03 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 23:31:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d38072d64d9cf323642ca7212b8b25e340e3a985
Cr-Commit-Position: refs/heads/master@{#323978}

Powered by Google App Engine
This is Rietveld 408576698