media/video/capture/fake_video_capture_device.cc - Issue 1064703002: VideoCaptureBufferPool: Refactor to allow support of non-ShMem backed buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/fake_video_capture_device.cc

Issue 1064703002: VideoCaptureBufferPool: Refactor to allow support of non-ShMem backed buffers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: miu@s nits Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_texture_wrapper.cc ('k') | media/video/capture/fake_video_capture_device_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/video/capture/fake_video_capture_device.cc

diff --git a/media/video/capture/fake_video_capture_device.cc b/media/video/capture/fake_video_capture_device.cc

index 5e5c387427c3c3060dff0a35f2865f638c0ab097..4f3a8bb7d62ae73569cf634d7c8991239f89f5a0 100644

--- a/media/video/capture/fake_video_capture_device.cc

+++ b/media/video/capture/fake_video_capture_device.cc

@@ -156,7 +156,7 @@ void FakeVideoCaptureDevice::CaptureUsingClientBuffers() {

DCHECK(thread_checker_.CalledOnValidThread());

const scoped_refptr<VideoCaptureDevice::Client::Buffer> capture_buffer =

- client_->ReserveOutputBuffer(VideoFrame::I420,

+ client_->ReserveOutputBuffer(capture_format_.pixel_format,

capture_format_.frame_size);

DLOG_IF(ERROR, !capture_buffer) << "Couldn't allocate Capture Buffer";

if (!capture_buffer)