Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1064663002: Gaia loading screen changed to align with new Sync screen UI (Closed)

Created:
5 years, 8 months ago by Nikita (slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gaia loading screen changed to align with new Sync screen UI Based on https://codereview.chromium.org/1040143002/ BUG=470114 Committed: https://crrev.com/c4d260fa056a03e61d452eea43ee35714f187729 Cr-Commit-Position: refs/heads/master@{#323918}

Patch Set 1 #

Patch Set 2 : register element only once #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/throbber_notice.html View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nikita (slow)
5 years, 8 months ago (2015-04-06 17:07:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064663002/20001
5 years, 8 months ago (2015-04-06 17:08:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54298)
5 years, 8 months ago (2015-04-06 17:17:09 UTC) #6
dzhioev (left Google)
On 2015/04/06 17:17:09, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-06 17:54:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064663002/20001
5 years, 8 months ago (2015-04-06 17:57:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-06 18:30:27 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 18:36:46 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4d260fa056a03e61d452eea43ee35714f187729
Cr-Commit-Position: refs/heads/master@{#323918}

Powered by Google App Engine
This is Rietveld 408576698