Fix scroll regression when specifying an extension id.

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // ExtensionFocusRow:
 
 /**
@@ skipping 272 matching lines @@
           // id.
           extensions.sort(compareExtensions);
           this.extensions_ = extensions;
           this.showExtensionNodes_();
           resolve();
         }.bind(this));
       }.bind(this));
       return this.extensionsUpdated_;
     },
 
+    /**
+     * Updates any element that needs to be visible to update properly.
+     * @param {boolean} visible Whether the extension list is visible.
+     */
+    updateVisibility: function(visible) {
+      if (!visible)

[Dan Beam, 2015/04/14 20:33:56]

i guess I see why you're doing this but it's certainly weird to have an
updateVisibility() that only cares about showing...

[not at google - send to devlin, 2015/04/14 20:38:50]

Yeah - it looks odd to me to only be using the parameter to decide whether the
function does anything. Seems like, at the moment, it should be handled at the
call site... if (hasExtensions) extensionList.updateVisibility().

[hcarmona, 2015/04/14 21:03:17]

Moved the visibility check to the call site and renamed the method to better
convey that it should be called when the list is visible.

+        return;
+
+      this.updateFocusableElements();
+
+      var idToHighlight = this.getIdQueryParam_();
+      if (idToHighlight && $(idToHighlight))
+        this.scrollToNode_(idToHighlight);
+
+      var idToOpenOptions = this.getOptionsQueryParam_();
+      if (idToOpenOptions && $(idToOpenOptions))
+        this.showEmbeddedExtensionOptions_(idToOpenOptions, true);
+    },
+
     /** @return {number} The number of extensions being displayed. */
     getNumExtensions: function() {
       return this.extensions_.length;
     },
 
     getIdQueryParam_: function() {
       return parseQueryParams(document.location)['id'];
     },
 
     getOptionsQueryParam_: function() {
@@ skipping 28 matching lines @@
               focusableNode.getEquivalentElement(
                   document.activeElement).focus();
             }
           }
 
           node.parentElement.removeChild(node);
           // Unregister the removed node from events.
           assertInstanceof(node, ExtensionFocusRow).destroy();
         }
       }
-
-      var idToHighlight = this.getIdQueryParam_();
-      if (idToHighlight && $(idToHighlight))
-        this.scrollToNode_(idToHighlight);
-
-      var idToOpenOptions = this.getOptionsQueryParam_();
-      if (idToOpenOptions && $(idToOpenOptions))
-        this.showEmbeddedExtensionOptions_(idToOpenOptions, true);
     },
 
     /** Updates each row's focusable elements without rebuilding the grid. */
     updateFocusableElements: function() {
       var rows = document.querySelectorAll('.extension-list-item-wrapper[id]');
       for (var i = 0; i < rows.length; ++i) {
         assertInstanceof(rows[i], ExtensionFocusRow).updateFocusableElements();
       }
     },
 
@@ skipping 698 matching lines @@
         var nextExt = this.extensions_[this.extensions_.indexOf(extension) + 1];
         this.createNode_(extension, nextExt ? $(nextExt.id) : null);
       }
     }
   };
 
   return {
     ExtensionList: ExtensionList
   };
 });