Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1064563005: blink:bindings: Temporarily disable ActivityLogApiTest. (Closed)

Created:
5 years, 8 months ago by Yuki
Modified:
5 years, 8 months ago
Reviewers:
felt
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink:bindings: Temporarily disable ActivityLogApiTest. In order to rename blink::EventTargetNames::LocalDOMWindow to blink::EventTargetNames::DOMWindow, we have to temporarily disable the test while the transition. Once the renaming gets done, we'll enable the test. The following CLs should be landed. http://crrev.com/1086663003 http://crrev.com/1088943008 NOPRESUBMIT=true BUG= Committed: https://crrev.com/1774a7204d11d9371fb037ee06f06a5264be86b1 Cr-Commit-Position: refs/heads/master@{#326748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/test/data/extensions/api_test/activity_log_private/test/test.js View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Yuki
Could you review this CL?
5 years, 8 months ago (2015-04-23 08:33:16 UTC) #2
felt
ok, lgtm, pls do make sure to reenable.
5 years, 8 months ago (2015-04-23 20:43:55 UTC) #3
Yuki
Thanks for the review. Will enable the test once Blink's change rolls.
5 years, 8 months ago (2015-04-24 04:31:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064563005/1
5 years, 8 months ago (2015-04-24 04:31:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/58727)
5 years, 8 months ago (2015-04-24 04:40:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064563005/1
5 years, 8 months ago (2015-04-24 06:20:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 06:20:46 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 06:21:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1774a7204d11d9371fb037ee06f06a5264be86b1
Cr-Commit-Position: refs/heads/master@{#326748}

Powered by Google App Engine
This is Rietveld 408576698