src/ia32/lithium-codegen-ia32.cc - Issue 106453003: Allocation site support for monomorphic StringAdds in BinaryOps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 106453003: Allocation site support for monomorphic StringAdds in BinaryOps. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Michael's comments. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index bba3acaa9a55ac059287d801acc552a7f6f70d69..0fd558794b2ad066f0a84d61d2cd867920f1d149 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -4918,7 +4918,7 @@ void LCodeGen::DoStringAdd(LStringAdd* instr) {

ASSERT(ToRegister(instr->left()).is(edx));

ASSERT(ToRegister(instr->right()).is(eax));

NewStringAddStub stub(instr->hydrogen()->flags(),

- isolate()->heap()->GetPretenureMode());

+ instr->hydrogen()->pretenure_flag());

CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);

} else {

EmitPushTaggedOperand(instr->left());

« src/hydrogen.cc ('K') | « src/ia32/code-stubs-ia32.cc ('k') | src/ic.h » ('j') | no next file with comments »