Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1064483002: ui/views: Remove redundant Save/Restore in LocationBarView. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
CC:
chromium-reviews, tfarina, enne (OOO), piman, sadrul, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/views: Remove redundant Save/Restore in LocationBarView. LocationBarView::PaintChildren does a Save/Restore around calling Paint on another View. But View::Paint() is non-virtual and already does a save/restore around any work that it does (eg around OnPaint()). So this is redundant work. R=pkasting BUG=466426 Committed: https://crrev.com/458cabc6e4595b530a2f2ac11d2e17587e3faf71 Cr-Commit-Position: refs/heads/master@{#323849}

Patch Set 1 #

Patch Set 2 : scopedcanvas: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danakj
This ScopedCanvas was introduced by https://codereview.chromium.org/302453002/diff/120001/chrome/browser/ui/views/location_bar/location_bar_view.cc which also added some clipping and moved the omnibox_view_ ...
5 years, 8 months ago (2015-04-03 22:48:54 UTC) #2
sky
LGTM
5 years, 8 months ago (2015-04-03 22:52:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064483002/20001
5 years, 8 months ago (2015-04-03 22:59:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-03 23:44:10 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 23:45:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/458cabc6e4595b530a2f2ac11d2e17587e3faf71
Cr-Commit-Position: refs/heads/master@{#323849}

Powered by Google App Engine
This is Rietveld 408576698