Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1064453002: Allow explicit navigations to "0.0.0.0" to support systems where this performs a (Closed)

Created:
5 years, 8 months ago by Peter Kasting
Modified:
5 years, 8 months ago
Reviewers:
Mark P
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow explicit navigations to "0.0.0.0" to support systems where this performs a navigation to localhost (in defiance of specs... but seemingly common). This still prevents navigation to any other IP with leading octet 0, and only allows 0.0.0.0 when it's actually entered in 4-component dotted-quad form. BUG=428046 TEST=Entering "0.0.0.0" in the address bar will navigate by default Committed: https://crrev.com/65e7a0403eb51c8490ee13e5da3ed8e544c34926 Cr-Commit-Position: refs/heads/master@{#323946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -24 lines) Patch
M components/omnibox/autocomplete_input.cc View 1 chunk +38 lines, -24 lines 0 comments Download
M components/omnibox/autocomplete_input_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Kasting
5 years, 8 months ago (2015-04-03 21:44:50 UTC) #2
Mark P
lgtm
5 years, 8 months ago (2015-04-06 18:31:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064453002/1
5 years, 8 months ago (2015-04-06 19:26:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 21:02:06 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 21:04:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65e7a0403eb51c8490ee13e5da3ed8e544c34926
Cr-Commit-Position: refs/heads/master@{#323946}

Powered by Google App Engine
This is Rietveld 408576698