src/scopes.cc - Issue 1064433008: Re-apply formal argument, arrow function parsing refactors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scopes.cc

Issue 1064433008: Re-apply formal argument, arrow function parsing refactors (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: Remove stale declaration that crept in with last patch Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/scopes.cc

diff --git a/src/scopes.cc b/src/scopes.cc

index 364f2f1cf7ce88ca08e207172c1cba1613dbb3f7..be991a1a17bc78acc8ae85aae36b4c9e45987979 100644

--- a/src/scopes.cc

+++ b/src/scopes.cc

@@ -452,7 +452,7 @@ Variable* Scope::Lookup(const AstRawString* name) {

Variable* Scope::DeclareParameter(const AstRawString* name, VariableMode mode,

- bool is_rest) {

+ bool is_rest, bool* is_duplicate) {

DCHECK(!already_resolved());

DCHECK(is_function_scope());

Variable* var = variables_.Declare(this, name, mode, Variable::NORMAL,

@@ -462,6 +462,8 @@ Variable* Scope::DeclareParameter(const AstRawString* name, VariableMode mode,

rest_parameter_ = var;

rest_index_ = num_parameters();

}

+ // TODO(wingo): Avoid O(n^2) check.

+ *is_duplicate = IsDeclaredParameter(name);

params_.Add(var, zone());

return var;

}