Issue 1064433005: Fix IWYU in fxcrt headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1064433005: Fix IWYU in fxcrt headers. (Closed)

Created:
5 years, 8 months ago by Tom Sepez

Modified:
5 years, 8 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix IWYU in fxcrt headers. Confirmed manually that: g++ --std=c++0x -o /dev/null -I. ... -c fx_xxxxx.h is now error-free for the files in this directory. Also kill some ifndef's around inclusion since we know this doesn't provide benefit with modern compilers. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6fcecb529007b65596f0ce30efde571f820df56b

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -31 lines)			Patch
M	core/include/fxcrt/fx_arb.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	core/include/fxcrt/fx_basic.h	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	core/include/fxcrt/fx_coordinates.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	core/include/fxcrt/fx_ext.h	View	3 chunks	+5 lines, -15 lines	0 comments	Download
M	core/include/fxcrt/fx_memory.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/include/fxcrt/fx_stream.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	core/include/fxcrt/fx_string.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	core/include/fxcrt/fx_ucd.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	core/include/fxcrt/fx_xml.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 8 months ago (2015-04-06 19:28:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6fcecb529007b65596f0ce30efde571f820df56b (presubmit successful).