Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1064433003: Revert "Trigger clean-up GCs between tests of Speedometer" (Closed)

Created:
5 years, 8 months ago by haraken
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Trigger clean-up GCs between tests of Speedometer" This reverts commit 3f8a241fe8b695f765f6c56ef57e4691f389c4c6. This was a wrong optimization to "improve" the performance of Speedomenter. We shouldn't have landed a change that is not adopted in the upstreamed Speedometer. TBR=peria@chromium.org Committed: https://crrev.com/f13b7592e312f69e70062fbcf72b746eefaf13fc Cr-Commit-Position: refs/heads/master@{#323885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/perf/benchmarks/speedometer.py View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
haraken
See Ryan's email for more details.
5 years, 8 months ago (2015-04-05 11:15:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064433003/1
5 years, 8 months ago (2015-04-05 11:16:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-05 12:13:22 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-05 12:14:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f13b7592e312f69e70062fbcf72b746eefaf13fc
Cr-Commit-Position: refs/heads/master@{#323885}

Powered by Google App Engine
This is Rietveld 408576698