OpenMAX requires armv7 or greater

OpenMAX requires armv7 or greater

BUG=234135
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239214

[Mostyn Bramley-Moore, 2013-12-05 12:08:11]

@Noam: does this look OK to you?

[Noam Samuel, 2013-12-05 15:10:42]

I think you might have the wrong Noam. I don't know anything about this cl.
On Dec 5, 2013 4:08 AM, <mostynb@opera.com> wrote:

> Reviewers: Noam Samuel,
>
> Message:
> @Noam: does this look OK to you?
>
> Description:
> OpenMAX requires armv7 or greater
>
> BUG=234135
>
> Please review this at https://codereview.chromium.org/106443003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+2, -2 lines):
>   M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index eed3623a0c373d4e40393845aaceede7df01fe0b..
> 23d0864ba6c81b86d68198c2deeb5b05f9622acf 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -787,8 +787,8 @@
>            'test_isolation_mode%': 'noop',
>          }],
>          # Whether Android ARM build uses OpenMAX DL FFT.
> -        ['OS=="android" and target_arch=="arm" and
> android_webview_build==0', {
> -          # Currently only supported on Android ARM, without webview.
> +        ['OS=="android" and target_arch=="arm" and arm_version >= 7 and
> android_webview_build==0', {
> +          # Currently only supported on Android ARMv7+, without webview.
>            # When enabled, this will also enable WebAudio on Android
>            # ARM.  Default is enabled.
>            'use_openmax_dl_fft%': 1,
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mostyn Bramley-Moore, 2013-12-05 15:17:44]

On 2013/12/05 15:10:42, Noam Samuel wrote:
> I think you might have the wrong Noam. I don't know anything about this cl.

Oops, sorry about that.  You were the last person to touch the OpenMAX comment
above this section, but it looks like that was just a trailing whitespace fixup.
 I'll look closer in the git history next time.

[Mostyn Bramley-Moore, 2013-12-05 15:19:30]

@rtoy, Paweł: PTAL...

[Raymond Toy (Google), 2013-12-05 17:49:13]

On 2013/12/05 15:19:30, Mostyn Bramley-Moore wrote:
> @rtoy, Paweł: PTAL...

LGTM.  

On a different note, do you want to run on chips older than arm v7?

[Mostyn Bramley-Moore, 2013-12-05 20:01:24]

On 2013/12/05 17:49:13, rtoy wrote:
> On 2013/12/05 15:19:30, Mostyn Bramley-Moore wrote:
> > @rtoy, Paweł: PTAL...
> 
> LGTM.  
> 
> On a different note, do you want to run on chips older than arm v7?

I don't think it's a very high priority for us (Opera), but we're not opposed to
adding armv6 OpenMAX.  However, I'm finding it quite difficult to track down
this API on ARM's website- all their relevant OpenMAX links are broken (even on
their internal search engine).

[commit-bot: I haz the power, 2013-12-05 20:10:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/106443003/1

[commit-bot: I haz the power, 2013-12-05 23:20:46]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[commit-bot: I haz the power, 2013-12-06 11:58:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/106443003/20001

[commit-bot: I haz the power, 2013-12-06 13:10:25]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[Torne, 2013-12-06 14:26:53]

The android_aosp failure is a broken trybot, but unfortunately many of the bots
for this builder are currently in the same broken state.

As one of the owners of the android_aosp configuration I am happy for this CL to
land anyway; it can't break us.

[Torne, 2013-12-06 14:27:14]

lgtm

[commit-bot: I haz the power, 2013-12-06 14:35:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/106443003/20001

[commit-bot: I haz the power, 2013-12-06 14:38:16]

Change committed as 239214