Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 106443002: 'make quickcheck': Assorted improvements. (Closed)

Created:
7 years ago by Jakob Kummerow
Modified:
7 years ago
CC:
v8-dev
Visibility:
Public.

Description

'make quickcheck': Assorted improvements. 'make ia32' should not build ia32.optdebug. 'make ia32.clean' should delete ia32.optdebug output. 'make quickcheck' should be terminatable by hitting Ctrl+C just once. R=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=18259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -39 lines) Patch
M Makefile View 2 chunks +2 lines, -1 line 0 comments Download
M tools/run-tests.py View 2 chunks +5 lines, -2 lines 0 comments Download
M tools/testrunner/local/commands.py View 3 chunks +39 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
Continuing my quest to make you happy. PTAL.
7 years ago (2013-12-05 11:34:00 UTC) #1
Benedikt Meurer
Nice work. LGTM
7 years ago (2013-12-05 12:27:22 UTC) #2
Dmitry Lomov (no reviews)
sheriff's notice: ok to land
7 years ago (2013-12-05 12:36:39 UTC) #3
Jakob Kummerow
7 years ago (2013-12-05 12:37:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18259.

Powered by Google App Engine
This is Rietveld 408576698