PlzNavigate: make RenderViewtest helper functions work

content/renderer/render_frame_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 546 matching lines @@
   // more.
   void SetPendingNavigationParams(
       scoped_ptr<NavigationParams> navigation_params);
 
  protected:
   RenderFrameImpl(RenderViewImpl* render_view, int32 routing_id);
 
  private:
   friend class RenderFrameImplTest;
   friend class RenderFrameObserver;
+  friend class RenderViewImplTest;

[clamy, 2015/04/08 14:19:30]

This is to not make the OnCommitNavigation handler public.

[carlosk, 2015/04/08 15:16:42]

Instead of friending the test you could call OnMessageReceived, which is public,
passing a FrameMsg_CommitNavigation. I saw that being done in
RenderFrameHostManagerTest.DetachPendingChild.

[clamy, 2015/04/09 15:55:06]

Considering Nasko's comment at line 539, I will have it as a friend here (this
will eventually allow to move OnNavigate back as a private member).

[Charlie Reis, 2015/04/09 16:04:51]

Actually, Nasko was referring to the FRIEND_TEST_ALL_PREFIXES lines below.  I'm
not sure if those will work for your new function?

We shouldn't have both the friend class and FRIEND_TEST_ALL_PREFIXES lines.  Can
you send a followup CL to choose one or the other?

   friend class RendererAccessibilityTest;
   FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuDisplayNoneTest, SelectItem);
   FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuRemoveTest, RemoveOnChange);
   FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuTest, NormalCase);
   FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuTest, ShowPopupThenNavigate);
   FRIEND_TEST_ALL_PREFIXES(RendererAccessibilityTest,
                            AccessibilityMessagesQueueWhileSwappedOut);
   FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest,
                            OnExtendSelectionAndDelete);
   FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, ReloadWhileSwappedOut);
@@ skipping 347 matching lines @@
 #endif
 
   base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_