PlzNavigate: make RenderViewtest helper functions work

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 1046 matching lines @@
 #endif
   IPC_END_MESSAGE_MAP()
 
   return handled;
 }
 
 void RenderFrameImpl::OnNavigate(
     const CommonNavigationParams& common_params,
     const StartNavigationParams& start_params,
     const RequestNavigationParams& request_params) {
+  CHECK(!base::CommandLine::ForCurrentProcess()->HasSwitch(

[clamy, 2015/04/08 14:19:30]

I added the CHECK to catch tests that manually call OnNavigate, and where we
don't properly exercise the PlzNavigate path.

[carlosk, 2015/04/08 15:16:42]

Good idea! Will make it way easier to find those many cases.

[Charlie Reis, 2015/04/09 00:47:40]

Sounds good.  Can you make this a DCHECK instead?  That will still run on both
the debug and release bots, but it won't get compiled into release builds for
users.

[clamy, 2015/04/09 15:55:06]

Done.

+      switches::kEnableBrowserSideNavigation));
   TRACE_EVENT2("navigation", "RenderFrameImpl::OnNavigate", "id", routing_id_,
                "url", common_params.url.possibly_invalid_spec());
 
   bool is_reload = IsReload(common_params.navigation_type);
   bool is_history_navigation = request_params.page_state.IsValid();
   WebURLRequest::CachePolicy cache_policy =
       WebURLRequest::UseProtocolCachePolicy;
   if (!RenderFrameImpl::PrepareRenderViewForNavigation(
           common_params.url, is_history_navigation, request_params, &is_reload,
           &cache_policy)) {
@@ skipping 3619 matching lines @@
 #elif defined(ENABLE_BROWSER_CDMS)
         cdm_manager_,
 #endif
         this);
   }
 
   return cdm_factory_;
 }
 
 }  // namespace content