Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1064333002: Get gn_all/gyp_remaining working for Windows. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get gn_all/gyp_remaining working for Windows. This change doesn't actually cause anything new to be built, but it makes 'gn_all' and 'gyp_remaining' exist as targets on a windows build, and explicitly lists all of the targets built on win that weren't listed before. A number of these targets should actually build in a GN build, but I will take care of that in a follow-up CL. R=brettw@chromium.org BUG=354261 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/eaef8f504d6e2a55626e2fb8b6c233f1d756d65c Cr-Commit-Position: refs/heads/master@{#324285}

Patch Set 1 #

Patch Set 2 : do not build crash_service_win64 on win64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -61 lines) Patch
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 1 11 chunks +169 lines, -60 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064333002/1
5 years, 8 months ago (2015-04-08 02:52:46 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54724)
5 years, 8 months ago (2015-04-08 03:02:03 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064333002/20001
5 years, 8 months ago (2015-04-08 04:46:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54737)
5 years, 8 months ago (2015-04-08 04:56:38 UTC) #8
Dirk Pranke
Brett, please take a look?
5 years, 8 months ago (2015-04-08 16:08:58 UTC) #9
brettw
LGTM rubberstamp
5 years, 8 months ago (2015-04-08 17:06:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1064333002/20001
5 years, 8 months ago (2015-04-08 18:47:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 21:16:48 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eaef8f504d6e2a55626e2fb8b6c233f1d756d65c Cr-Commit-Position: refs/heads/master@{#324285}
5 years, 8 months ago (2015-04-08 21:17:43 UTC) #14
Dirk Pranke
5 years, 8 months ago (2015-04-08 22:07:11 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1071603005/ by dpranke@chromium.org.

The reason for reverting is: Seems to have broken the Win x64 debug builder:

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20(dbg)....

Powered by Google App Engine
This is Rietveld 408576698