Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 106433010: Revert "android: Add CHECK() calls to better understand memory corruption." (Closed)

Created:
6 years, 11 months ago by Torne
Modified:
6 years, 11 months ago
Reviewers:
bulach, digit1
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Revert "android: Add CHECK() calls to better understand memory corruption." This reverts r237591. The added CHECK() breaks the Android WebView and was added to help diagnose a now-fixed bug that turned out to be unrelated. BUG=332079 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M base/android/jni_android.cc View 3 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Torne
Hi bulach, digit, Is it okay to just entirely revert this patch? The check it's ...
6 years, 11 months ago (2014-01-07 15:19:55 UTC) #1
digit1
lgtm. I think it's safe to remove it. We found and removed the original crashing ...
6 years, 11 months ago (2014-01-07 15:32:04 UTC) #2
bulach
lgtm, yeah, the original issue has been solved (thanks david!)
6 years, 11 months ago (2014-01-07 15:44:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/106433010/1
6 years, 11 months ago (2014-01-07 15:55:38 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242462
6 years, 11 months ago (2014-01-07 18:26:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/106433010/1
6 years, 11 months ago (2014-01-07 19:44:15 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 19:51:43 UTC) #7
Message was sent while issue was closed.
Change committed as 243367

Powered by Google App Engine
This is Rietveld 408576698