chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc - Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc ('k') | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

index dc0a6fb8ad065ff3c8bdf508db67da23e4cae19b..41a143a0aaf8ac37fceb2dfe772b22c2dac6872a 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

@@ -525,9 +525,9 @@ TEST_F(WebRequestRulesRegistryTest, IgnoreRulesByTag) {

" \"priority\": 300 \n"

"} ";

- scoped_ptr<Value> value1(base::JSONReader::Read(kRule1));

+ scoped_ptr<base::Value> value1(base::JSONReader::Read(kRule1));

ASSERT_TRUE(value1.get());

- scoped_ptr<Value> value2(base::JSONReader::Read(kRule2));

+ scoped_ptr<base::Value> value2(base::JSONReader::Read(kRule2));

ASSERT_TRUE(value2.get());

std::vector<linked_ptr<RulesRegistry::Rule> > rules;

@@ -689,7 +689,7 @@ TEST(WebRequestRulesRegistrySimpleTest, StageChecker) {

" \"priority\": 200 \n"

"} ";

- scoped_ptr<Value> value(base::JSONReader::Read(kRule));

+ scoped_ptr<base::Value> value(base::JSONReader::Read(kRule));

ASSERT_TRUE(value);

RulesRegistry::Rule rule;

@@ -722,7 +722,7 @@ TEST(WebRequestRulesRegistrySimpleTest, HostPermissionsChecker) {

" \"instanceType\": \"declarativeWebRequest.RedirectRequest\",\n"

" \"redirectUrl\": \"http://bar.com\" \n"

"} ";

- scoped_ptr<Value> action_value(base::JSONReader::Read(kAction));

+ scoped_ptr<base::Value> action_value(base::JSONReader::Read(kAction));

ASSERT_TRUE(action_value);

WebRequestActionSet::AnyVector actions;

@@ -778,7 +778,7 @@ TEST_F(WebRequestRulesRegistryTest, CheckOriginAndPathRegEx) {

" \"priority\": 200 \n"

"} ";

- scoped_ptr<Value> value(base::JSONReader::Read(kRule));

+ scoped_ptr<base::Value> value(base::JSONReader::Read(kRule));

ASSERT_TRUE(value.get());

std::vector<linked_ptr<RulesRegistry::Rule> > rules;