chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc - Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc

Issue 106433007: Update some uses of Value in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc

index b557633e5503ccc3b02dafa3aac9e5057e053d87..e9d84a690b73c83137a125a94400ea36856b1349 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc

@@ -154,7 +154,7 @@ scoped_ptr<WebRequestCondition> WebRequestCondition::Create(

for (base::DictionaryValue::Iterator iter(*condition_dict);

!iter.IsAtEnd(); iter.Advance()) {

const std::string& condition_attribute_name = iter.key();

- const Value& condition_attribute_value = iter.value();

+ const base::Value& condition_attribute_value = iter.value();

const bool name_is_url = condition_attribute_name == keys::kUrlKey;

if (condition_attribute_name == keys::kInstanceTypeKey) {

// Skip this.